SuccessChanges

Summary

  1. dsme-wdd-wd.c: Fix GCC string truncation error. (details)
  2. debian/changelog: Bump for version 0.61.5. (details)
  3. dsme-wdd-wd.c: set watchdog_path size to 16 bytes (details)
  4. Add cross-compiling support (details)
  5. Move dsme-thermal logic from init script to libexec (details)
  6. [systemd] Use systemctl commands for shutdown/reboot (details)
  7. Add systemd support (details)
  8. Fix warning: dsme wdd: Couldn't remove lockfile (details)
  9. Minor fix (details)
  10. Update debian/changelog (0.61.6) (details)
  11. Add LSB headers to init scripts (details)
  12. Update debian/changelog (0.61.7) (details)
Commit ef42b52858e609c004565cfbb027cf0b7a84bf45 by Ivan J.
dsme-wdd-wd.c: Fix GCC string truncation error.

This fixes issue #297 on the Maemo Leste bugtracker.

Compiling with GCC 8.3.0 gives the following error:
dsme-wdd-wd.c:236:38: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
                      "/dev/watchdog%d", i);
                                      ^
dsme-wdd-wd.c:235:13: note: 'snprintf' output between 15 and 16 bytes into a destination of size 15
             snprintf(watchdog_path, sizeof(watchdog_path),
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                      "/dev/watchdog%d", i);
                      ~~~~~~~~~~~~~~~~~~~~~

Some fiddling around seems to confirm this is a false positive.

We have fixed this however by changing the array size to 32 instead of
disabling the check in question.
The file was modifieddsme-wdd-wd.c (diff)
Commit 5a77e540672f107ff51d2323d74a295fa89e6a8a by Ivan J.
debian/changelog: Bump for version 0.61.5.
The file was modifieddebian/changelog (diff)
Commit 14c2d856d7650e8527ff786051c57d738db9174e by Arthur D.
dsme-wdd-wd.c: set watchdog_path size to 16 bytes

According to my research 16 bytes is enough to both suppress gcc warning
and to be able to safely store up to 99 watchdogs
The file was modifieddsme-wdd-wd.c (diff)
Commit 147f0d0513c8e7f1ff0e8def932a2bdb9918a27a by Arthur D.
Add cross-compiling support
The file was modifieddebian/rules (diff)
Commit 6befea756d3ba008171e04ac210c791b11106518 by Arthur D.
Move dsme-thermal logic from init script to libexec

This is needed because we can't use parts of bash scripts in systemd
service files
The file was modifieddebian/dsme-thermal.init (diff)
The file was addedscripts/dsme-thermal
The file was modifieddebian/rules (diff)
Commit 9d357e27c855c5761a33e03402b896380a8f4f35 by Arthur D.
[systemd] Use systemctl commands for shutdown/reboot
The file was modifiedmodules/runlevel.c (diff)
The file was addeddebian/dsme.socket
The file was modifiedMakefile (diff)
The file was modifieddsmesock.c (diff)
The file was modifieddsme-wdd.c (diff)
The file was modifieddsme-server.c (diff)
The file was addeddebian/dsme-thermal.service
The file was addeddebian/dsme.service
The file was modifieddebian/control (diff)
The file was modifieddebian/rules (diff)
The file was addeddebian/dsme-dbus.service
Commit e15f232a0e941806163c020bb72554df21aa2a5b by Arthur D.
Fix warning: dsme wdd: Couldn't remove lockfile

DSME doesn't create a lockfile, if it's not running in daemon mode
The file was modifieddsme-wdd.c (diff)
The file was modifieddsme-wdd.c (diff)
Commit 30961e0513ac27295420e1445c9ad238fd576780 by Arthur D.
Update debian/changelog (0.61.6)
The file was modifieddebian/changelog (diff)
Commit b601ab7a68465cc1e13f78bf076ba2584455452c by Arthur D.
Add LSB headers to init scripts
The file was modifieddebian/dsme-dbus.init (diff)
The file was modifieddebian/dsme.init (diff)
The file was modifieddebian/dsme-thermal.init (diff)
Commit 7302012a4251d8ddfa03712470c6b42f8c976656 by Arthur D.
Update debian/changelog (0.61.7)
The file was modifieddebian/changelog (diff)