SuccessChanges

Summary

  1. dsme-wdd-wd.c: Fix GCC string truncation error. (details)
  2. debian/changelog: Bump for version 0.61.5. (details)
  3. dsme-wdd-wd.c: set watchdog_path size to 16 bytes (details)
  4. Add cross-compiling support (details)
  5. Move dsme-thermal logic from init script to libexec (details)
  6. [systemd] Use systemctl commands for shutdown/reboot (details)
  7. Add systemd support (details)
  8. Update debian/changelog (0.61.6) (details)
Commit 83eb11fea953bd5911170b3bcdba538c178e2c2a by bas
dsme-wdd-wd.c: Fix GCC string truncation error.

This fixes issue #297 on the Maemo Leste bugtracker.

Compiling with GCC 8.3.0 gives the following error:
dsme-wdd-wd.c:236:38: error: 'snprintf' output may be truncated before the last format character [-Werror=format-truncation=]
                      "/dev/watchdog%d", i);
                                      ^
dsme-wdd-wd.c:235:13: note: 'snprintf' output between 15 and 16 bytes into a destination of size 15
             snprintf(watchdog_path, sizeof(watchdog_path),
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                      "/dev/watchdog%d", i);
                      ~~~~~~~~~~~~~~~~~~~~~

Some fiddling around seems to confirm this is a false positive.

We have fixed this however by changing the array size to 32 instead of
disabling the check in question.
The file was modifieddsme-wdd-wd.c (diff)
Commit 449f06c1eab380c9bebec741c6223998131c96ef by bas
debian/changelog: Bump for version 0.61.5.
The file was modifieddebian/changelog (diff)
Commit cfe558666d86e4226624e2690f7016adef981c09 by Arthur D.
dsme-wdd-wd.c: set watchdog_path size to 16 bytes

According to my research 16 bytes is enough to both suppress gcc warning
and to be able to safely store up to 99 watchdogs
The file was modifieddsme-wdd-wd.c (diff)
Commit 972033943841dfb17dcbdd0ccb1bf5aae3856215 by Arthur D.
Add cross-compiling support
The file was modifieddebian/rules (diff)
Commit a0a8a9495c67870c62618f3270637a0054f68837 by Arthur D.
Move dsme-thermal logic from init script to libexec

This is needed because we can't use parts of bash scripts in systemd
service files
The file was modifieddebian/dsme-thermal.init (diff)
The file was modifieddebian/rules (diff)
The file was addedscripts/dsme-thermal
Commit d10020f7ef51cea6e6e541ddf33d71617824dab6 by Arthur D.
[systemd] Use systemctl commands for shutdown/reboot
The file was modifiedmodules/runlevel.c (diff)
The file was modifieddebian/rules (diff)
The file was addeddebian/dsme-dbus.service
The file was addeddebian/dsme.service
The file was modifieddsme-server.c (diff)
The file was modifieddsme-wdd.c (diff)
The file was addeddebian/dsme.socket
The file was addeddebian/dsme-thermal.service
The file was modifieddebian/control (diff)
The file was modifieddsmesock.c (diff)
The file was modifiedMakefile (diff)
Commit dc735467ffc10edc98e6cab7737a78b6694417fa by Arthur D.
Update debian/changelog (0.61.6)
The file was modifieddebian/changelog (diff)